Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates stack documentation formatting and adjusts model-related environment variable handling in docker-compose.yml for the Agent API service.
Changes:
- Reformat several README diagrams/blocks/tables for improved Markdown rendering and readability.
- Simplify the “Nhóm Models” environment variable table in the README (removing the docker-compose default column).
- Remove docker-compose fallback defaults for
CODING_PLANNER_MODEL,TL_MODEL, andCLARIFIER_MODELin theagent-apiservice.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Markdown formatting and presentation tweaks for architecture diagrams, workflow steps, and environment variable docs. |
| docker-compose.yml | Changes agent-api model env var interpolation to no longer provide compose-level defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| OLLAMA_REQUEST_TIMEOUT: ${OLLAMA_REQUEST_TIMEOUT:-1200} | ||
| OLLAMA_CONTEXT_LENGTH: ${OLLAMA_CONTEXT_LENGTH:-32768} | ||
| CODING_PLANNER_MODEL: ${CODING_PLANNER_MODEL:-granite3.3:2b} | ||
| CODING_PLANNER_MODEL: ${CODING_PLANNER_MODEL} |
Comment on lines
+154
to
+157
| TL_MODEL: ${TL_MODEL} | ||
| TESTER_MODEL: ${TESTER_MODEL} | ||
| DEVSECOPS_MODEL: ${DEVSECOPS_MODEL} | ||
| CLARIFIER_MODEL: ${CLARIFIER_MODEL:-qwen3.6:35b} | ||
| CLARIFIER_MODEL: ${CLARIFIER_MODEL} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.