Add redeem and redeemWith#3146
Merged
Merged
Conversation
This was referenced Nov 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #3146 +/- ##
==========================================
- Coverage 93.28% 93.25% -0.03%
==========================================
Files 376 376
Lines 7323 7343 +20
Branches 195 186 -9
==========================================
+ Hits 6831 6848 +17
- Misses 492 495 +3
Continue to review full report at Codecov.
|
rossabaker
approved these changes
Nov 14, 2019
rossabaker
left a comment
rossabaker
left a comment
Member
There was a problem hiding this comment.
Delighted to see this one arrive.
gagandeepkalra
added a commit
to gagandeepkalra/cats
that referenced
this pull request
Mar 8, 2020
travisbrown
pushed a commit
that referenced
this pull request
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes @alexandru's first commit from #2237 but removes the
EitherTenhancements and focuses on the part that fixes #2161 (newredeemandredeemWithmethods).See typelevel/cats-effect#191 for additional discussion.
I still think we should try to get the
EitherTimprovements merged, butredeemseems like a higher priority for 2.1.0. I've also reverted some other changes in the original commit in order to preserve binary compatibility.Note that I've moved
redeemfromMonadErrortoApplicativeErrorand have added syntax and syntax tests.