Skip to content

Make catsInstancesForIdCompat2_6_1 package-private #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armanbilge merged 1 commit into from
Apr 19, 2022
Merged

Make catsInstancesForIdCompat2_6_1 package-private #4191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/cats/Invariant.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ object Invariant extends ScalaVersionSpecificInvariantInstances with InvariantIn
cats.catsInstancesForId
@deprecated("Added for bincompat", "2.8.0")
@cats.compat.targetName("catsInstancesForId")

@satorg satorg Apr 19, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide some details on how this guy is supposed to work please? I think it might help me with my work in #4187.

@armanbilge armanbilge Apr 19, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, do you mean about the compat thing or the semantics of targetName which is a Scala 3 feature? You can see how it works in #4143 (comment).

def catsInstancesForIdCompat2_6_1: Comonad[Id] =
private[cats] def catsInstancesForIdCompat2_6_1: Comonad[Id] =
cats.catsInstancesForId
implicit def catsMonadErrorForEither[A]: MonadError[Either[A, *], A] =
cats.instances.either.catsStdInstancesForEither[A]
Expand Down