Skip to content

Add collectFirst to the NonEmptyCollection interface#4275

Merged
armanbilge merged 1 commit into
typelevel:mainfrom
opencastsoftware:nonempty-collectfirst
Jul 28, 2022
Merged

Add collectFirst to the NonEmptyCollection interface#4275
armanbilge merged 1 commit into
typelevel:mainfrom
opencastsoftware:nonempty-collectfirst

Conversation

@DavidGregory084

@DavidGregory084 DavidGregory084 commented Jul 28, 2022

Copy link
Copy Markdown
Contributor

This work was initially done on PR #4193 to support the cats.data.HashMap implementation, but now that that PR is being retargeted onto cats-collections I'd like to make sure this change isn't lost.

@armanbilge armanbilge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@armanbilge armanbilge added this to the 2.9.0 milestone Jul 28, 2022

@danicheg danicheg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armanbilge

Copy link
Copy Markdown
Member

Merging since I assume the snapshot will unblock the PR retargeting. Thanks for all your work on that btw.

@armanbilge
armanbilge merged commit ba69c19 into typelevel:main Jul 28, 2022
@DavidGregory084
DavidGregory084 deleted the nonempty-collectfirst branch July 28, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants