Add fs2-grpc-otel4s-trace module#843
Merged
Merged
Conversation
Collaborator
|
I will take a look at the PR tomorrow :) |
ahjohannessen
approved these changes
Apr 22, 2026
Collaborator
ahjohannessen
left a comment
ahjohannessen
left a comment
There was a problem hiding this comment.
Great work 👍
Not sure if other eyes are needed on this one.
Contributor
Author
|
The public API surface is rather small, and we can make binary-compatible changes in the future. Perhaps we can merge the changes and then we will get a snapshot? A snapshot should be enough to test this implementation in different private environments. |
Collaborator
|
Not sure how to publish snapshots, but I am merging it. |
Collaborator
|
@iRevive I have released v3.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As otel4s approaches 1.0.0, it makes sense for fs2-grpc to provide first-class tracing instrumentation.
This PR adds an
fs2-grpc-otel4s-tracemodule with client and service aspects for OpenTelemetry tracing via otel4s. The implementation follows the current OpenTelemetry gRPC semantic conventions for span kind, span names, RPC attributes, gRPC status codes, and error classification.The core concept was already tested in a few prod environments via https://github.com/iRevive/fs2-grpc-otel4s.