Skip to content

fix(abg): Only consider refs with exactly three parts#2306

Merged
krzema12 merged 2 commits into
mainfrom
vampire/exclude-non-versions
Apr 27, 2026
Merged

fix(abg): Only consider refs with exactly three parts#2306
krzema12 merged 2 commits into
mainfrom
vampire/exclude-non-versions

Conversation

@Vampire

@Vampire Vampire commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@Vampire Graphite App

Vampire commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Vampire

Vampire commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator Author

Currently, in https://bindings.krzeminski.it/actions/checkout___major/maven-metadata.xml you get silent-rev-parse and toolkit-windows-exec from https://github.com/actions/checkout/branches/all?query=vmj vmjoseph/toolkit-windows-exec and vmjoseph/silent-rev-parse, because we search for all refs starting with v and then only take the part after the last slash.
With this PR only the relevant refs are considered.

@Vampire Vampire force-pushed the vampire/exclude-non-versions branch from 9bc9c36 to 25d925c Compare April 25, 2026 17:10
@Vampire Vampire requested a review from krzema12 April 25, 2026 17:11
@Vampire Vampire force-pushed the vampire/exclude-non-versions branch from 25d925c to 94ac60e Compare April 25, 2026 21:40
@Vampire Vampire force-pushed the vampire/exclude-non-versions branch from 94ac60e to 363bf89 Compare April 25, 2026 21:43
@krzema12 krzema12 mentioned this pull request Apr 27, 2026
Merged
krzema12 added a commit that referenced this pull request Apr 27, 2026
@krzema12 @Vampire
test: add test for listing versions for branches and tags starting wi…
f6049ca 
…th 'v' (#2310)

Adding a test before fixing the problem in
#2306.

Co-authored-by: Björn Kautler <Bjoern@Kautler.net>
@krzema12 krzema12 enabled auto-merge (squash) April 27, 2026 10:35
@krzema12 krzema12 merged commit 0a2b5dc into main Apr 27, 2026
17 checks passed
@krzema12 krzema12 deleted the vampire/exclude-non-versions branch April 27, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krzema12 krzema12 krzema12 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vampire @krzema12