Feat: use inner <T as ToTypesenseField>::to_typesense_type() of Vec<T> in derive#85
Merged
RoDmitry merged 2 commits intoMay 6, 2026
Conversation
Collaborator
|
Nice solution 👍 |
7fabd17 to
e9fbcc7
Compare
Contributor
Author
|
Super! Yes, looks good and things are still happy on my side. :) |
RoDmitry
approved these changes
May 6, 2026
<T as ToTypesenseField>::to_typesense_type() of Vec<T> in derive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Deriving Typesense on a struct with a
Vec<MyLocalType>field only compiles ifMyLocalType: Document(giving "object[]") or is a built-in primitive. And we cannot doimpl ToTypesenseField for Vec<MyLocalType>in downstream crates, so requires the#[typesense(type = "...")]per-field work around.This PR mirrors what
build_regular_fieldalready does for flatten: peel Vec<_> (and Vec<Option<_>>) in the proc-macro, resolveToTypesenseFieldon the inner type, and append"[]". Downstream crates now only needMyLocalType: ToTypesenseField.Example that compiles after this PR but not before:
PR Checklist