Skip to content

fix: ignore client-provided resource IDs #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typicode merged 1 commit into from
Mar 20, 2026
+5 −2
Merged

fix: ignore client-provided resource IDs #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,13 @@ await test('find', async (t) => {

await test('create', async () => {
const post = { title: 'new post' }
const res = await service.create(POSTS, post)
let res = await service.create(POSTS, post)
assert.equal(res?.['title'], post.title)
assert.equal(typeof res?.['id'], 'string', 'id should be a string')

res = await service.create(POSTS, { ...post, id: 'foo' })
assert.notEqual(res?.['id'], 'foo', 'user should not be able to set id')

assert.equal(await service.create(UNKNOWN_RESOURCE, post), undefined)
})

Expand Down
2 changes: 1 addition & 1 deletion src/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export class Service {
const items = this.#get(name)
if (items === undefined || !Array.isArray(items)) return

const item = { id: randomId(), ...data }
const item = { ...data, id: randomId() }
items.push(item)

await this.#db.write()
Expand Down