Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds linting for GitHub Actions workflows by introducing a new actions job that uses a reusable workflow from the typisttech/.github repository.
- Adds a new
actionsjob to the lint workflow that callslint-actions.yml@v3 - Positions the new job before existing
phpandgolint jobs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+20
to
+21
| actions: | ||
| uses: typisttech/.github/.github/workflows/lint-actions.yml@v3 |
There was a problem hiding this comment.
The new actions job should be added to the needs list in the wait-for-all-lint job (line 32-34). Currently, only php and go are listed as dependencies, but the actions lint job should also be included to ensure all linting jobs complete before the wait-for-all-lint job runs.
| jobs: | ||
| actions: | ||
| uses: typisttech/.github/.github/workflows/lint-actions.yml@v3 | ||
|
|
There was a problem hiding this comment.
Remove the trailing whitespace on this blank line to maintain consistency with the rest of the file.
Suggested change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.