Fix lane viewer UI layout and datastream fetching limits#158
Fix lane viewer UI layout and datastream fetching limits#158tyronechrisharris wants to merge 2 commits into
Conversation
…id heights - Fix `lane-view/page.tsx` rendering to conditionally wrap the `EventTable` and `StatusTable` instead of using `display: none / block` to prevent the `DataGrid` 0px height collapse via MUI resize container. - Update `Node.ts` datastream fetching methods (`fetchDataStreams` and `fetchLaneControlStreams`) to chunk API calls in batches of 10. This avoids silent API truncation/URI length limits when 50+ lanes are requested at once. - Update `LaneCollection.ts` to use `.includes(obsProperty)` instead of exact match (`===`) to ensure mock and varied stream definitions reliably match `ALARM_DEF` and `TAMPER_STATUS_DEF`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…id heights - Fix `lane-view/page.tsx` rendering to conditionally wrap the `EventTable` and `StatusTable` instead of using `display: none / block` to prevent the `DataGrid` 0px height collapse via MUI resize container. - Update `Node.ts` datastream fetching methods (`fetchDataStreams` and `fetchLaneControlStreams`) to chunk API calls in batches of 10. This avoids silent API truncation/URI length limits when 50+ lanes are requested at once. - Update `LaneCollection.ts` to use `.includes(obsProperty)` instead of exact match (`===`) to ensure mock and varied stream definitions reliably match `ALARM_DEF` and `TAMPER_STATUS_DEF`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
1 participant
This pull request fixes two distinct issues reported when connecting numerous (e.g. 50) lanes to the viewer:
MUI X DataGrid Height Collapse: Removed CSS
display: block / nonelayout toggling on the mainDataGridparent containers inlane-view/page.tsx. By enforcing React-level conditional rendering, the tables correctly compute their dimensions upon mounting, fixing theuseResizeContainererror.Missing Live Data/Alarms on Many Lanes: When the application bootstrapped, fetching datastreams for all lanes passed an exhaustive string of IDs (
system: laneIds.join(",")) causing URI limit/silent truncation bugs with thesearchDataStreamsendpoint. ThefetchDataStreamsandfetchLaneControlStreamsfunctions inNode.tshave been refactored to chunk requests in batches of 10. Additionally, updated string evaluation when discovering observed properties likeALARM_DEFto safely use.includesinstead of strict matching to handle multiple URI formats.PR created automatically by Jules for task 13531737641037477763 started by @tyronechrisharris