Skip to content

Fix CRLF line endings for batch files#4

Open
tyronechrisharris wants to merge 1 commit into
mainfrom
fix-crlf-bat-7148262657258030820
Open

Fix CRLF line endings for batch files#4
tyronechrisharris wants to merge 1 commit into
mainfrom
fix-crlf-bat-7148262657258030820

Conversation

@tyronechrisharris

Copy link
Copy Markdown
Owner

The user reported an issue with monitor-oscar.bat throwing errors stating "The system cannot find the batch label specified". This is a common issue on Windows when executing batch files that have Unix-style (LF) instead of Windows-style (CRLF) line endings.

To fix this, I added a .gitattributes file that instructs Git to check out *.bat files with CRLF endings across all platforms. Then, I converted all the .bat files within the repository and submodules to use CRLF using unix2dos and committed the changes, resulting in updated submodule pointers as well.


PR created automatically by Jules for task 7148262657258030820 started by @tyronechrisharris

Windows `cmd.exe` fails to resolve batch labels (`goto` statements) when batch scripts use Unix-style (`LF`) line endings. This commit resolves this issue by:
1. Adding a `.gitattributes` file to enforce CRLF line endings for `*.bat` files.
2. Converting existing `.bat` files to CRLF.
3. Updating submodules where batch files were modified to use CRLF.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant