Conversation
|
@SunilMohanAdapa @aouaki Is there any change you guys could do code review for me? |
|
@tzangms I'd be happy to. Will try to do this as soon as find some time (today/tomorrow). |
| context = {'form': element, 'classes': markup_classes} | ||
|
|
||
|
|
||
| if django_version < (1, 11): |
There was a problem hiding this comment.
This should be < (1, 8) since using Context instances has been deprecated as of Django 1.8
| context = Context(context) | ||
|
|
||
| if django_version >= (1, 8): | ||
| context = context.flatten() |
|
Reviewed |
|
Hi All, Sorry for the late reply, I've did some modify suggested by @aouaki https://pypi.python.org/pypi/django-bootstrap-form/3.3 Please test before put on production, thanks! |
|
@tzangms Thanks for the quick response. |
|
Sorry to poke again, but will the merge also solve https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=865938 ? That's the current issue threatening Plinth to be deleted from Debian, I don't have time to look at this right now. |
|
Hi @JoKeyser I've take a looks at the detail, but is there any document to follow to solve this problem? |
|
Hi @tzangms , thank you looking into this! And sorry, I also don't know what the best answer is here. Probably @SunilMohanAdapa or @jvalleroy or @petterreinholdtsen know what the best solution is. In my understanding, the Debian maintainer or another Debian developer(?) would have to finally upload a working (i.e. building-from-source) package to the Debian archive. You (and maybe tomorrow, me) could help by checking whether the problem of bug 865938 would still exist in the current version, now that this PR got merged. Sorry, I just don't have time today. |
|
Oh, I think I miss read the message in Debian bug report page, obviously there is a test error should be fixed, though the unit test is passed in every test on Travis CI. |
|
I'm sorry, my previous 2 posts were confusing (because I was confused myself). |
5 participants
No description provided.