add [[clang::lifetimebound]] attributes where suggested#140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang 23 adds several new diagnostic warnings (
-Wlifetime-safetyclass) that can detect certain classes of dangling references. This warning suggests to add [[clang::lifetimebound]] to a number of methods that reference object parameters. To maintain the goal of building TMC + examples/tests without any warnings, I've added these attributes in the examples also. This change isn't because of changes in TMC; the TMC attributes aren't transitive to the examples. The attributes being added here are specific to the examples code itself.