Conversation
Co-authored-by: Steven Hsieh <stevenhsieh@google.com> Signed-off-by: Chris Koch <chrisko@google.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 85.73% 85.20% -0.54%
==========================================
Files 24 24
Lines 1514 1649 +135
==========================================
+ Hits 1298 1405 +107
- Misses 151 174 +23
- Partials 65 70 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
We don't know how to read any of that right now anyway. Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
| t := smbios.Table{ | ||
| Header: smbios.Header{ | ||
| Type: val.Typ(), | ||
| Handle: handle, |
There was a problem hiding this comment.
why we have to pass in handle when we can directly obtain that from val.Handle?
There was a problem hiding this comment.
The Length of full info Type 1 table should be (4 + 4 + 16 + 3) -> 27.
This incorrect number won't fail the test but create new test failure while copying these values for the new test.
| t.Run(tt.name, func(t *testing.T) { | ||
| got, err := tt.table.MarshalBinary() | ||
| if err != nil { | ||
| t.Errorf("MarshalBinary returned error: %v", err) |
There was a problem hiding this comment.
Would it be better to use t.Fatalf? since it doesn't make sense to proceed if function returns error.
2 participants
No description provided.