doc: add html_lookup template for the CGI keyserver UI#5
Open
mneme-2026 wants to merge 2 commits into
Open
Conversation
A small standalone HTML lookup page (using milligram.min.css) that can be mounted in front of the onak CGI to give end users a clean search form for op=index / op=vindex / op=get. Original author: piseb <piseb@mailo.com> (October 2025), shipped initially under debian/extra/doc/html_lookup/ in the foopgp Debian packaging of onak. Repackaged here under doc/html_lookup/ so it is available upstream and ships in every distribution-side build. Forwarded by Mnêmê <mneme@foopgp.org> on behalf of foopgp.
u1f35c
reviewed
May 27, 2026
u1f35c
left a comment
u1f35c
left a comment
Owner
There was a problem hiding this comment.
I like the idea of a nice lookup page being shipped, but I think it needs a couple of cleanups before I can merge it.
| <body> | ||
| <div class="container"> | ||
|
|
||
| <h1><a href="https://the.earth.li">Onak</a> Public Key Server</h1> |
Owner
There was a problem hiding this comment.
I'd rather not default to linking to this top level link for onak. Possibly the GitHub page instead?
| @@ -0,0 +1,56 @@ | |||
| <head> | |||
Owner
There was a problem hiding this comment.
This is a generated file without source, so I can't include it in the Debian packaging as is. However I note that there's a libjs-milligram package so perhaps we can drop this file and just Suggests that instead?
Per u1f35c review on PR u1f35c#5 : - Drop the embedded milligram.min.css. It's a generated (minified) artifact without source, which precludes Debian packaging. Replace by a <link> to the libjs-milligram package's milligram.css served at /javascript/milligram/milligram.css (path provided by the standard javascript-common alias). Suggest adding `libjs-milligram` to Suggests: in debian/control. - Move the four custom CSS rules (form label, .container, #keytext, .display-block) from the bottom of the dropped CSS file into a short inline <style> block in the document head, where they're trivially reviewable. - Replace the h1 link from https://the.earth.li (u1f35c's personal site) to https://github.com/u1f35c/onak per the reviewer's preference.
Author
|
Both points addressed in ac0c343, thanks for the review !
Happy to move the inline overrides into a separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small standalone HTML lookup page using
milligram.min.cssthat can be mounted in front of the onak CGI to give end users a clean search form forop=index/op=vindex/op=get.Original author: Sébastien Picardeau (then a foopgp contributor), who first shipped it in our Debian packaging under
debian/extra/doc/html_lookup/(commit86a3a82in our foopgp/onak fork on Codeberg). The page is repackaged here underdoc/html_lookup/so it ships in every distribution build rather than only the Debian one — but if you prefer a different layout (e.g.examples/, or staying debian-only), say so and I'll relocate.Submitted on behalf of foopgp (Friends of OpenPGP).