Skip to content

fix(ruler): round display mm on rotated labels to drop float noise #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
u8array merged 1 commit into from
May 10, 2026
Merged

fix(ruler): round display mm on rotated labels to drop float noise #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/components/Canvas/Ruler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,12 @@ export function Ruler({
strokeWidth={isMajor ? 1 : 0.5}
listening={false} />,
);
const displayMm = horizontalReversed ? labelWidthMm - mm : mm;
// `mm` was rounded above; subtraction reintroduces IEEE-754 artefacts
// (e.g. 100 - 30 = 70.00000000000001), so re-round to keep tick labels
// free of trailing-decimal noise on rotated labels.
const displayMm = horizontalReversed
? Math.round((labelWidthMm - mm) * 1000) / 1000
: mm;
if (isMajor && displayMm > 0 && displayMm <= labelWidthMm) {
els.push(
<Text key={`ht-${i}`}
Expand Down Expand Up @@ -92,7 +97,9 @@ export function Ruler({
strokeWidth={isMajor ? 1 : 0.5}
listening={false} />,
);
const displayMm = verticalReversed ? labelHeightMm - mm : mm;
const displayMm = verticalReversed
? Math.round((labelHeightMm - mm) * 1000) / 1000
: mm;
Comment thread
u8array marked this conversation as resolved.
if (isMajor && displayMm > 0 && displayMm <= labelHeightMm) {
els.push(
<Text key={`vt-${i}`}
Expand Down