feat: Implement snap-to-grid and object snapping for resize#5
Merged
Conversation
Introduces snap-to-grid functionality for resizing labels, mirroring the behavior of drag-and-drop snapping. Also enhances object snapping during resize operations, ensuring visual alignment with other elements on the canvas. This includes logic for deriving active edges during resize and computing snap points based on proximity to other objects and the label boundary.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces object-snapping for element resizing, allowing objects to align with other canvas elements and label boundaries during transformation. The implementation includes a refactor of the snapping logic into reusable helpers, the addition of edge-tracking to determine active resize boundaries, and new unit tests. Feedback suggests replacing hardcoded padding values with constants and considering the extension of snapping support to restricted barcode types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces snap-to-grid functionality for resizing labels, mirroring the behavior of drag-and-drop snapping. Also enhances object snapping during resize operations, ensuring visual alignment with other elements on the canvas. This includes logic for deriving active edges during resize and computing snap points based on proximity to other objects and the label boundary.