feat: Add ZPL import append mode#57
Merged
Merged
Conversation
Introduces an "append mode" for ZPL imports, allowing users to add imported pages to an existing design without overwriting it. This includes a new toggle and corresponding locale keys.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an 'append mode' for ZPL imports, allowing users to add imported pages to an existing design instead of overwriting it. It includes updates to the labelStore to support page appending, UI changes in ZplImportModal to toggle this mode, and necessary localization updates. The reviewer noted that the file import handler is missing validation for empty results, which should be addressed to match the manual text import logic.
Mirror the manual-paste validation in handleFileSelect: if the parsed file contains no supported objects and no label-config changes, show the same 'No supported objects found' message instead of silently no-op'ing (append mode) or clearing the design (replace mode). Findings from Gemini on PR #57.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces an "append mode" for ZPL imports, allowing users to add imported pages to an existing design without overwriting it. This includes a new toggle and corresponding locale keys.