Feat/element lock visibility#59
Merged
Merged
Conversation
Implement object locking to prevent accidental edits and allow users to exclude objects from ZPL output. - Locked objects are no longer draggable, resizable, or deletable. - The "Include in ZPL output" checkbox in the Properties panel controls whether an object is exported. - Added corresponding translations for the new features. - Updated tests to cover locking behavior and ZPL exclusion.
Introduces `objectIdsAtPoint` to abstract Konva hit testing and a new `buildBulkToggleUpdates` helper to encapsulate the logic for toggling properties in the LayersPanel. This refactoring improves code clarity and reusability.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces object locking, visibility controls, and ZPL export exclusion. Locking prevents transformation and deletion while maintaining editability for specific meta-fields. Visibility and export settings allow users to hide objects from the canvas or omit them from ZPL output independently. The UI is updated with new controls in the Layers and Properties panels, along with keyboard shortcuts for locking. Feedback suggests refining the bulk toggle logic to use undefined for default states, ensuring consistency with the Properties panel and keeping the persisted JSON clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.