refactor(registry): extract Leaf<T,P> helper for LeafObject union#65
Merged
Conversation
The 31 branches of `LeafObject` repeated the same
`LabelObjectBase & { type: 'X'; props: P }` pattern verbatim. Extract
a local `Leaf<T, P>` alias so each branch fits on one short line and
adding a new registry entry is a one-line union extension instead of
a 60-character repetition.
Pure mechanical edit; the resulting type is structurally identical
to the previous union (TypeScript inference treats the alias as
transparent), so no consumer sees a different shape.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the LeafObject union type in src/registry/index.ts by introducing a Leaf helper type, which significantly reduces boilerplate code. Feedback suggests improving type safety by constraining the generic props parameter to object and recommends moving this helper to a shared types file to further reduce duplication across the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.