Docs/readme canvas limitation#70
Merged
Merged
Conversation
Both shapes now wrap body + a dedicated EllipseSelectionOverlay in a top-left-anchored Group, matching the box pattern. The selection blue traces the declared outer bbox instead of re-stroking the inset body, so a thick outline shape keeps the marker on its outer pixel. Drops nodeOrigin: 'center' from the ellipse/circle registries since the Group origin is now top-left; the transformer reads node.x()/y() directly without the center-to-top-left conversion.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes the coordinate system for canvas objects by wrapping center-anchored shapes, such as ellipses and circles, in a top-left positioned Group. This change simplifies the transformation logic, enabling the removal of the transformNodeTopLeft utility and the nodeOrigin property from object definitions. Additionally, the README.md was updated to clarify text rendering limitations in the canvas preview. Feedback was provided to update a documentation comment in KonvaObject.tsx to accurately reflect that all shapes are now wrapped in a Group node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.