Skip to content

fix(lint): remove useless null initializer in buildBwipOptions #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
u8array merged 1 commit into from
May 20, 2026
Merged

fix(lint): remove useless null initializer in buildBwipOptions #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/Canvas/bwipHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,11 @@ export function buildBwipOptions(
// needed.
const rotation = objectRotation(obj.props);

let opts: Record<string, unknown> | null = null;
// Declared without an initializer because every reachable case
// assigns before `break` and the `default` arm returns early — the
// previous `= null` initializer is what ESLint 10's
// no-useless-assignment now flags as dead.
let opts: Record<string, unknown>;

switch (obj.type) {
case "ean13":
Expand Down Expand Up @@ -498,7 +502,7 @@ export function buildBwipOptions(
return null;
}

if (opts && rotation !== "N") {
if (rotation !== "N") {
// ZPL uses N/R/I/B (B = 270° CW). bwip-js uses N/R/I/L (L = 90° CCW =
// 270° CW). The other three letters mean the same thing in both.
opts.rotate = rotation === "B" ? "L" : rotation;
Expand Down