fix(parser): render ^GFA zero-bits as transparent, not opaque white#82
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ZPL parser's handling of the ^GF command to ensure that 0-bits are rendered as transparent instead of opaque white, correctly reflecting ZPL behavior. Review feedback suggests translating the newly added German comments into English for consistency and optimizing the pixel processing loop by removing redundant RGB assignments, as the ImageData buffer is already initialized to zero.
0-bits used to be rendered as rgba(255,255,255,255) and obscured underlying objects. ZPL defines 0-bits as not-printed; in the canvas preview that maps to transparent so layered fields stay visible. createImageData starts zero-filled (rgba(0,0,0,0)), which already is the 0-bit case — only the 1-bit pixels need an alpha write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.