Add support for custom pip arguments and exclude option#25
Open
mvanderlee wants to merge 10 commits intoubaniabalogun:masterfrom
Open
Add support for custom pip arguments and exclude option#25mvanderlee wants to merge 10 commits intoubaniabalogun:masterfrom
mvanderlee wants to merge 10 commits intoubaniabalogun:masterfrom
Conversation
Add ability to exclude glob patterns and exclude the following by default: * "**/.serverless", * "**/node_modules", * "**/requirements.txt", * "**/package.json", * "**/package-lock.json"
mvanderlee
changed the title
By excluding the function's requirements file it wasn't actually installed anymore
Ensuring a function's requirements file overrides the global one.
Previously, every time a new version came out, this would simply fail until you updated pip. This obviously shouldn't happen.
Pip 10 will log error messages about broken dependencies. This is interpreted by serverless as an actual error and we don't want that. So disable the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issues #23 and #24