Open
Conversation
__dict__ is an implementation detail. We should avoid using it. Fixes uber#93.
|
|
1 similar comment
Contributor
Author
|
Before merging this I need to add tests. |
Contributor
Author
|
So it turns out this library indeed doesn't support partial doubles. I'd appreciate a code review before going any further. |
Contributor
|
@thedrow what do you mean by "indeed doesn't support partial doubles"? Do you have an example? |
Contributor
|
I'm not sure this will solve the problem, because we get errors like I have to think more about how to support objects with |
Contributor
Author
|
Exactly my point but at least with this PR we get a clearer error message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__dict__is an implementation detail. We should avoid using it.Fixes #93.