Cover failure cases in gridDisk, gridRing, etc#1195
Merged
Conversation
|
coverage: 99.363% (+0.2%) from 99.176% — isaacbrodsky:grid-disk-coverage into uber:master |
dfellis
approved these changes
Jul 22, 2026
justinhwang
approved these changes
Jul 22, 2026
| "Should return an error when starting at a pentagon"); | ||
| } | ||
|
|
||
| TEST(onPentagon) { |
Contributor
There was a problem hiding this comment.
nit: give them different test names
Suggested change
| TEST(onPentagon) { | |
| TEST(onPentagon_failed) { |
Collaborator
Author
There was a problem hiding this comment.
Updated, thanks!
justinhwang
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with #1193, I used Claude to generate examples that exercised the case that gridDisk, gridRingUnsafe, etc. recurse into another cell that then fails. They all require combinations on invalid cells (deleted K subsequence of a pentagon, or invalid digits).