Skip to content

Cover cases in polygonToCells which fail after estimation #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaacbrodsky merged 2 commits into from
Jul 24, 2026
+46 −5
Merged

Cover cases in polygonToCells which fail after estimation #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d8f48b
Cover cases in polygonToCells which fail after estimation
isaacbrodsky Jul 24, 2026
ab9ec10
Test name
isaacbrodsky Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions src/apps/testapps/testPolygonToCells.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,19 @@ static LatLng invalid2Verts[] = {{NAN, NAN}, {-NAN, -NAN}};
static GeoLoop invalid2GeoLoop = {.numVerts = 2, .verts = invalid2Verts};
static GeoPolygon invalid2GeoPolygon;

static LatLng invalidSfVerts[] = {
{0.659966917655, -2.1364398519396}, {NAN, -2.1359434279405},
{0.6583348114025, -2.1354884206045}, {0.6581220034068, -2.1382437718946},
{0.6594479998527, -2.1384597563896}, {0.6599990002976, -2.1376771158464}};
static GeoLoop invalidSfGeoLoop = {.numVerts = 6, .verts = invalidSfVerts};
static GeoPolygon invalidSfGeoPolygon;

static LatLng invalidHoleVerts[] = {{0.6595072188743, -2.1371053983433},
{0.6591482046471, NAN},
{0.6592295020837, -2.1365222838402}};
static GeoLoop invalidHoleGeoLoop = {.numVerts = 3, .verts = invalidHoleVerts};
static GeoPolygon invalidHoleGeoPolygon;

static LatLng pointVerts[] = {{0, 0}};
static GeoLoop pointGeoLoop = {.numVerts = 1, .verts = pointVerts};
static GeoPolygon pointGeoPolygon;
Expand Down Expand Up @@ -159,6 +172,13 @@ SUITE(polygonToCells) {
lineGeoPolygon.geoloop = lineGeoLoop;
lineGeoPolygon.numHoles = 0;

invalidSfGeoPolygon.geoloop = invalidSfGeoLoop;
invalidSfGeoPolygon.numHoles = 0;

invalidHoleGeoPolygon.geoloop = sfGeoLoop;
invalidHoleGeoPolygon.numHoles = 1;
invalidHoleGeoPolygon.holes = &invalidHoleGeoLoop;

// --------------------------------------------
// maxPolygonToCellsSize
// --------------------------------------------
Expand Down Expand Up @@ -493,6 +513,32 @@ SUITE(polygonToCells) {
free(hexagons);
}

TEST(polygonToCells_oneNanVertex) {
int64_t numHexagons;
t_assertSuccess(H3_EXPORT(maxPolygonToCellsSize)(&invalidSfGeoPolygon,
9, 0, &numHexagons));
H3Index *hexagons = calloc(numHexagons, sizeof(H3Index));

t_assert(H3_EXPORT(polygonToCells)(&invalidSfGeoPolygon, 9, 0,
hexagons) == E_FAILED,
"Partially NAN geo polygon cannot be evaluated");

free(hexagons);
}

TEST(polygonToCells_oneNanHoleVertex) {
int64_t numHexagons;
t_assertSuccess(H3_EXPORT(maxPolygonToCellsSize)(&invalidHoleGeoPolygon,
9, 0, &numHexagons));
H3Index *hexagons = calloc(numHexagons, sizeof(H3Index));

t_assert(H3_EXPORT(polygonToCells)(&invalidHoleGeoPolygon, 9, 0,
hexagons) == E_FAILED,
"Partially NAN geo polygon cannot be evaluated (hole)");

free(hexagons);
}

TEST(fillIndex) {
iterateAllIndexesAtRes(0, fillIndex_assertions);
iterateAllIndexesAtRes(1, fillIndex_assertions);
Expand Down
5 changes: 0 additions & 5 deletions src/h3lib/lib/algos.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,6 @@ H3Error H3_EXPORT(gridDiskDistancesUnsafe)(H3Index origin, int k, H3Index *out,
if (neighborResult) {
// Should not be possible because `origin` would have to be a
// pentagon
// TODO: Reachable via fuzzer
return neighborResult;
}

Expand Down Expand Up @@ -812,7 +811,6 @@ H3Error H3_EXPORT(gridRingUnsafe)(H3Index origin, int k, H3Index *out) {
if (neighborResult) {
// Should not be possible because `origin` would have to be a
// pentagon
// TODO: Reachable via fuzzer
return neighborResult;
}

Expand All @@ -833,7 +831,6 @@ H3Error H3_EXPORT(gridRingUnsafe)(H3Index origin, int k, H3Index *out) {
if (neighborResult) {
// Should not be possible because `origin` would have to be a
// pentagon
// TODO: Reachable via fuzzer
return neighborResult;
}

Expand Down Expand Up @@ -1055,7 +1052,6 @@ H3Error H3_EXPORT(polygonToCells)(const GeoPolygon *geoPolygon, int res,
&numSearchHexes, search, found);
// If this branch is reached, we have exceeded the maximum number of
// hexagons possible and need to clean up the allocated memory.
// TODO: Reachable via fuzzer
if (edgeHexError) {
H3_MEMORY(free)(search);
H3_MEMORY(free)(found);
Expand All @@ -1074,7 +1070,6 @@ H3Error H3_EXPORT(polygonToCells)(const GeoPolygon *geoPolygon, int res,
search, found);
// If this branch is reached, we have exceeded the maximum number of
// hexagons possible and need to clean up the allocated memory.
// TODO: Reachable via fuzzer
if (edgeHexError) {
H3_MEMORY(free)(search);
H3_MEMORY(free)(found);
Expand Down
Loading