feat(queue): per-partition isolation and fix subscriber shutdown race conditions#108
Merged
Conversation
sbalabanov
approved these changes
Mar 3, 2026
f759829 to
e4e03fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workerWgtracks partition workers independently from the supervisor.workerWg.Wait()blocks before closingdeliveryChto prevent sends on a closed channel. Workers are removed from the map immediately on stop so reconciliation can start replacements without zombie entries.Test plan
TestConsumer_PerPartitionProcessing— verifies a slow partition A does not block partition BTestConsumer_PartitionOrdering— verifies messages within a single partition are processed in orderTestConsumer_PartitionWorkerCleanup— verifies all partition goroutines exit cleanly on Stop()TestSubscriber_ReconcilePartitionWorkers— verifies workers are started/stopped based on lease changesTestSubscriber_PartitionWorkerPollAndDeliver— verifies a partition worker delivers messagesTestSubscriber_StopAllWorkers— verifies all workers stop gracefullybazel test