Skip to content

feat(ci): add lint, tidy, and formatting CI jobs#116

Merged
behinddwalls merged 1 commit into
mainfrom
preetam/ci
Mar 6, 2026
Merged

feat(ci): add lint, tidy, and formatting CI jobs#116
behinddwalls merged 1 commit into
mainfrom
preetam/ci

Conversation

@behinddwalls
Copy link
Copy Markdown
Collaborator

@behinddwalls behinddwalls commented Mar 4, 2026

Summary

  • Replace custom yamllint Go tool with yamlfmt (google/yamlfmt) via go run
  • Replace gofmt with goimports for Go formatting + import grouping
  • Remove custom coverage tool and all CI coverage enforcement
  • Add assert_clean pattern for lint checks (format, then verify no changes)
  • Integrate license header checking into lint pipeline

Test plan

  • make build passes
  • make test — all 25 unit tests pass
  • make fmt — goimports and yamlfmt run successfully
  • Verify no remaining references to coverage or yamllint

Test Plan

Issues

@behinddwalls behinddwalls requested review from a team and sbalabanov as code owners March 4, 2026 06:04
@behinddwalls behinddwalls force-pushed the preetam/ci branch 8 times, most recently from 8e4357d to d185d90 Compare March 4, 2026 06:47
@behinddwalls behinddwalls changed the title feat(ci): add lint, tidy, and formatting CI jobs feat(ci): add lint, tidy, coverage, and formatting CI jobs Mar 4, 2026
@behinddwalls behinddwalls force-pushed the preetam/ci branch 2 times, most recently from 87c9de7 to dded6ef Compare March 4, 2026 07:16
@behinddwalls behinddwalls force-pushed the preetam/ci branch 2 times, most recently from 239a667 to e31ebc5 Compare March 4, 2026 07:22
@uber uber deleted a comment from github-actions Bot Mar 4, 2026
@behinddwalls behinddwalls changed the title feat(ci): add lint, tidy, coverage, and formatting CI jobs feat(ci): add CI workflow with lint, coverage, and formatting Mar 4, 2026
@uber uber deleted a comment from github-actions Bot Mar 4, 2026
@uber uber deleted a comment from github-actions Bot Mar 4, 2026
@uber uber deleted a comment from github-actions Bot Mar 4, 2026
Comment thread doc/howto/COVERAGE.md Outdated
Comment thread tool/coverage/BUILD.bazel
@uber uber deleted a comment from github-actions Bot Mar 4, 2026
@uber uber deleted a comment from github-actions Bot Mar 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2026

Caution

Coverage enforcement has been exempted for this PR via the COVERAGE_EXEMPTION label.
Reviewers: please verify this exemption is justified before approving.

Coverage: 78.7% (3311/4207 lines)
Diff coverage: 65.6% (332/506 new lines)

Package Coverage Lines Diff New Lines
core/consumer 84.1% 344/409 - -
core/errs 100.0% 48/48 - -
core/metrics 100.0% 71/71 - -
entity 100.0% 33/33 - -
entity/github 96.3% 52/54 - -
entity/queue 100.0% 23/23 - -
extension/mergechecker 87.5% 14/16 - -
extension/mergechecker/github 91.7% 132/144 - -
extension/queue 100.0% 21/21 100.0% 4/4
extension/queue/mysql ⚠️ 67.1% 983/1464 - -
extension/queue/mysql/ctl 100.0% 0/0 - -
extension/queue/mysql/ctl/lib ⚠️ 77.1% 239/310 - -
extension/scorer/composite 100.0% 45/45 - -
extension/scorer/heuristic 100.0% 20/20 - -
gateway/controller 92.9% 131/141 - -
orchestrator/controller 100.0% 34/34 - -
orchestrator/controller/batch 85.9% 128/149 - -
orchestrator/controller/build 93.6% 88/94 - -
orchestrator/controller/buildsignal 93.4% 85/91 - -
orchestrator/controller/conclude 100.0% 53/53 - -
orchestrator/controller/merge 86.1% 87/101 - -
orchestrator/controller/request 93.6% 88/94 - -
orchestrator/controller/score 93.0% 80/86 - -
orchestrator/controller/speculate 86.4% 89/103 - -
orchestrator/controller/validate 94.1% 95/101 - -
tool/coverage ⚠️ 65.1% 295/453 ⚠️ 65.1% 295/453
tool/linter/yamllint ⚠️ 67.3% 33/49 ⚠️ 67.3% 33/49

Overall threshold (80%) is enforced. Diff threshold (85%) is informational.

View full coverage report

@behinddwalls behinddwalls requested a review from sbalabanov March 5, 2026 06:10
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

Caution

Coverage enforcement has been exempted for this PR via the COVERAGE_EXEMPTION label.
Reviewers: please verify this exemption is justified before approving.

Coverage: 79.0% (3371/4269 lines)
Diff coverage: 65.6% (332/506 new lines)

Package Coverage Lines Diff New Lines
core/consumer 84.1% 344/409 - -
core/errs 100.0% 48/48 - -
core/metrics 100.0% 71/71 - -
core/request 100.0% 31/31 - -
entity 100.0% 61/61 - -
entity/github 96.3% 52/54 - -
entity/queue 100.0% 23/23 - -
extension/mergechecker 87.5% 14/16 - -
extension/mergechecker/github 91.7% 132/144 - -
extension/queue 100.0% 21/21 100.0% 4/4
extension/queue/mysql ⚠️ 67.1% 983/1464 - -
extension/queue/mysql/ctl 100.0% 0/0 - -
extension/queue/mysql/ctl/lib ⚠️ 77.1% 239/310 - -
extension/scorer/composite 100.0% 45/45 - -
extension/scorer/heuristic 100.0% 20/20 - -
gateway/controller 91.7% 132/144 - -
orchestrator/controller 100.0% 34/34 - -
orchestrator/controller/batch 85.9% 128/149 - -
orchestrator/controller/build 93.6% 88/94 - -
orchestrator/controller/buildsignal 93.4% 85/91 - -
orchestrator/controller/conclude 100.0% 53/53 - -
orchestrator/controller/merge 86.1% 87/101 - -
orchestrator/controller/request 93.6% 88/94 - -
orchestrator/controller/score 93.0% 80/86 - -
orchestrator/controller/speculate 86.4% 89/103 - -
orchestrator/controller/validate 94.1% 95/101 - -
tool/coverage ⚠️ 65.1% 295/453 ⚠️ 65.1% 295/453
tool/linter/yamllint ⚠️ 67.3% 33/49 ⚠️ 67.3% 33/49

Overall threshold (80%) is enforced. Diff threshold (85%) is informational.

View full coverage report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

Caution

Coverage enforcement has been exempted for this PR via the COVERAGE_EXEMPTION label.
Reviewers: please verify this exemption is justified before approving.

Coverage: 78.9% (3380/4283 lines)
Diff coverage: 65.6% (332/506 new lines)

Package Coverage Lines Diff New Lines
core/consumer 83.8% 352/420 - -
core/errs 96.1% 49/51 - -
core/metrics 100.0% 71/71 - -
core/request 100.0% 31/31 - -
entity 100.0% 61/61 - -
entity/github 96.3% 52/54 - -
entity/queue 100.0% 23/23 - -
extension/mergechecker 87.5% 14/16 - -
extension/mergechecker/github 91.7% 132/144 - -
extension/queue 100.0% 21/21 100.0% 4/4
extension/queue/mysql ⚠️ 67.1% 983/1464 - -
extension/queue/mysql/ctl 100.0% 0/0 - -
extension/queue/mysql/ctl/lib ⚠️ 77.1% 239/310 - -
extension/scorer/composite 100.0% 45/45 - -
extension/scorer/heuristic 100.0% 20/20 - -
gateway/controller 91.7% 132/144 - -
orchestrator/controller 100.0% 34/34 - -
orchestrator/controller/batch 85.9% 128/149 - -
orchestrator/controller/build 93.6% 88/94 - -
orchestrator/controller/buildsignal 93.4% 85/91 - -
orchestrator/controller/conclude 100.0% 53/53 - -
orchestrator/controller/merge 86.1% 87/101 - -
orchestrator/controller/request 93.6% 88/94 - -
orchestrator/controller/score 93.0% 80/86 - -
orchestrator/controller/speculate 86.4% 89/103 - -
orchestrator/controller/validate 94.1% 95/101 - -
tool/coverage ⚠️ 65.1% 295/453 ⚠️ 65.1% 295/453
tool/linter/yamllint ⚠️ 67.3% 33/49 ⚠️ 67.3% 33/49

Overall threshold (80%) is enforced. Diff threshold (85%) is informational.

View full coverage report

@behinddwalls behinddwalls changed the title feat(ci): add CI workflow with lint, coverage, and formatting feat(ci): add lint, tidy, and formatting CI jobs Mar 6, 2026
@behinddwalls behinddwalls force-pushed the preetam/ci branch 2 times, most recently from 13b38de to 6b743a1 Compare March 6, 2026 20:24
Comment thread tool/coverage/BUILD.bazel
Comment thread tool/coverage/BUILD.bazel
Replace custom Go tools with external formatters:
- yamlfmt (google/yamlfmt) instead of custom yamllint
- goimports instead of gofmt for import grouping
- Remove coverage tool and all CI coverage enforcement
- Add license header checking to lint pipeline
@behinddwalls behinddwalls added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit b7b27ab Mar 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants