feat(batch): Reimplement batch controller for consistency#138
Merged
Conversation
sbalabanov
commented
Mar 11, 2026
sbalabanov
force-pushed
the
sergeyb/batch
branch
from
76752dc to
8176eaf
Compare
BatchDependent is a secondary index stucture to Batch entity, make it fully eventually consistent: - Give it more comments - Always create with batch creation so next batch won't have to guess - Remove metadata, it won't be used, at least not for state tracking as it gets stale - Ensure order of operations - dependents first, empty dependent entry second, batch itself to follow, and then queue - Additional comments added explaining the further stale state reconciliation logic
behinddwalls
force-pushed
the
sergeyb/batch
branch
from
8176eaf to
32b6cf3
Compare
behinddwalls
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BatchDependent is a secondary index stucture to Batch entity, make it
fully eventually consistent:
gets stale
second, batch itself to follow, and then queue
reconciliation logic
Test Plan
Issues
Stack