refactor(gateway): publish via TopicRegistry; align orchestrator topic names with keys#150
Merged
Merged
Conversation
…c names with keys Make the gateway Land controller resolve its publish target through consumer.TopicRegistry instead of taking a Publisher and topic-name string directly. The destination is hardcoded to consumer.TopicKeyStart, mirroring how orchestrator/controller/start hardcodes TopicKeyValidate as its publish destination. The gateway never subscribes, so it does not need a topicKey field on the struct. In example/server/orchestrator, rename TopicKeyStart's topic name "request" to "start" and consumer group "orchestrator-request" to "orchestrator-start" so every stage's topic and consumer-group names match its TopicKey, matching the convention already used by validate, batch, score, etc. In example/server/gateway, build a publish-only TopicRegistry containing a single entry for TopicKeyStart and pass it to NewLandController.
This was referenced May 7, 2026
sbalabanov
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the gateway Land controller resolve its publish target through
consumer.TopicRegistry instead of taking a Publisher and topic-name string
directly. The destination is hardcoded to consumer.TopicKeyStart, mirroring
how orchestrator/controller/start hardcodes TopicKeyValidate as its publish
destination. The gateway never subscribes, so it does not need a topicKey
field on the struct.
In example/server/orchestrator, rename TopicKeyStart's topic name "request"
to "start" and consumer group "orchestrator-request" to "orchestrator-start"
so every stage's topic and consumer-group names match its TopicKey, matching
the convention already used by validate, batch, score, etc.
In example/server/gateway, build a publish-only TopicRegistry containing a
single entry for TopicKeyStart and pass it to NewLandController.
Test Plan
bazel build, bazel test
Issues
Stack