refactor(change): persist typed change details from the change provider#195
Open
behinddwalls wants to merge 1 commit into
Open
refactor(change): persist typed change details from the change provider#195behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
This was referenced Jun 4, 2026
behinddwalls
force-pushed
the
change-details
branch
from
89968ae to
2f34df7
Compare
This was referenced Jun 4, 2026
sbalabanov
approved these changes
Jun 4, 2026
| package entity | ||
|
|
||
| // User represents the author of a change. | ||
| type User struct { |
Contributor
There was a problem hiding this comment.
User is very generic name. May be "ChangeAuthor" or "Author" ?
| type ChangedFile struct { | ||
| // Path is the file path relative to the repository root. | ||
| Path string `json:"path"` | ||
| // Patch is the diff patch content for this file. |
Contributor
There was a problem hiding this comment.
Do we always store it? If not, may be give expectations.
| return fmt.Errorf("failed to marshal details for change record queue=%s uri=%s request_id=%s: %w", record.Queue, record.URI, record.RequestID, err) | ||
| } | ||
|
|
||
| const query = "UPDATE `change` SET details = ?, updated_at = ?, version = ? WHERE queue = ? AND uri = ? AND request_id = ? AND version = ?" |
Contributor
There was a problem hiding this comment.
If details contain a patch, wouldn't it be expensive to rewrite it every time?
| // record for this request. For each info it reads the record at (queue, info.URI, | ||
| // request.ID) — the row start.claimURIs created — and conditionally writes the | ||
| // details, bumping the version. A missing record or a lost version race surfaces | ||
| // as ErrVersionMismatch, treated as a benign no-op so redelivery stays idempotent. |
Contributor
There was a problem hiding this comment.
why don't we make it immutable and fixed at Change info creation, or have separate entities and datastores for immutable/mutable fields?
behinddwalls
force-pushed
the
change-store
branch
from
3a1a203 to
9af42e1
Compare
behinddwalls
force-pushed
the
change-details
branch
from
2f34df7 to
a0d29b9
Compare
behinddwalls
force-pushed
the
change-store
branch
from
dd27fec to
c61303e
Compare
behinddwalls
force-pushed
the
change-details
branch
from
a0d29b9 to
d991a29
Compare
## Summary ### Why? The change provider already produces rich per-URI facts (author, changed files, line counts), but its value types lived in the extension layer and the data was thrown away — validate fetched ChangeInfo only to log a file count, and ChangeRecord stored an opaque Metadata JSON string that was never written. Nothing downstream could read typed change facts. ### What? - Move the change value types into entities: entity.User, entity.ChangedFile (now with LinesModified), entity.ChangeDetails (the facts), and entity.ChangeInfo (URI -> Details), with aggregation helpers. The changeprovider extension and GitHub impl now produce these. - Replace ChangeRecord.Metadata (opaque string) with typed Details (ChangeDetails); the change table's metadata JSON column becomes details. - Add ChangeStore.UpdateDetails — a version-guarded conditional write, following the optimistic-locking contract (arithmetic in the controller). - validate now persists each fetched ChangeInfo onto the request's change records (per-URI, idempotent; ErrVersionMismatch is a benign no-op). This is the producer half: typed details now exist and are persisted. The score controller consumes them in a follow-up. ## Test Plan - ✅ `make build`, `make test`, `make lint`, `make check-mocks/gazelle/tidy` - ✅ `make integration-test` (storage contract suite round-trips Details and covers UpdateDetails create/update/version-mismatch)
behinddwalls
force-pushed
the
change-store
branch
from
c61303e to
771be50
Compare
behinddwalls
force-pushed
the
change-details
branch
from
d991a29 to
c979c6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
The change provider already produces rich per-URI facts (author, changed
files, line counts), but its value types lived in the extension layer and
the data was thrown away — validate fetched ChangeInfo only to log a file
count, and ChangeRecord stored an opaque Metadata JSON string that was never
written. Nothing downstream could read typed change facts.
What?
(now with LinesModified), entity.ChangeDetails (the facts), and
entity.ChangeInfo (URI -> Details), with aggregation helpers. The
changeprovider extension and GitHub impl now produce these.
(ChangeDetails); the change table's metadata JSON column becomes details.
following the optimistic-locking contract (arithmetic in the controller).
records (per-URI, idempotent; ErrVersionMismatch is a benign no-op).
This is the producer half: typed details now exist and are persisted. The
score controller consumes them in a follow-up.
Test Plan
make build,make test,make lint,make check-mocks/gazelle/tidymake integration-test(storage contract suite round-trips Details andcovers UpdateDetails create/update/version-mismatch)
Issues
Stack