feat(storage) Implement sample MySQL storage engine for Requests#27
Merged
Conversation
behinddwalls
approved these changes
Feb 19, 2026
Contributor
Author
|
ah, now a stacked commit is merged into this branch 👎 Github workflow is so awesomely flawed. |
Wire MySQL implementation to Controller and example services. Revamped all of e2e test infra to make things work by using Testcontainers-Go and docker network. It is quite slow now (~30 sec) but it is kinda hermetic. Will improve runtime in next iterations. Co-authored-by: sergeyb <sergeyb@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
First attempt to implement real storage while keeping required characteristics like optimistic locking and autogenerated IDs
What?
extensions/storage/mysql implementation for Request entity and MYSQL schema
Test Plan
No tests; will implement integration test with real MySQL as a next step