feat(counter): Implement global atomic counter for sequential ID generation#33
Merged
Conversation
behinddwalls
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global atomic counter generates and stores the maximum value across dynamic categories. Used to generate sequential identifiers for entities. Backed by MySQL storage with atomic increment operations.
Switched Request entity implementation to use counter-based approach, eliminated the use of a (queue,seq) pair as a primary key.
It might happen that the counter value is globally incremented but the returned value is not used - for example, the server crashed straight after value retrieval. This might leave gaps in entity id sequence and is considered normal, as long as numbers are sequential.
This approach simplifies entity handling a lot, especially within the need to reference another entity.
Could be used to generate IDs for other entities as well, such as Batch or SpeculationPath.