refactor(queue): move config to per-subscription SubscriptionConfig#38
Merged
Conversation
Different subscriptions may need different settings (timeouts, retry policies, batch sizes). Moving config from queue-level to Subscribe() enables per-topic customization without creating separate Queue instances. - Add SubscriptionConfig with SubscriberName, ConsumerGroup, polling, retry, and DLQ settings - Remove queue-level Config from SQL queue (now empty Params) - Update Subscriber.Subscribe() to accept SubscriptionConfig - Pass config parameters to stores instead of reading from struct fields - Update e2e tests to use new subscription-based config pattern - Fix: use fresh context with timeout for graceful lease release on shutdown to prevent context.Canceled errors leaving partitions orphaned
behinddwalls
force-pushed
the
preetam/queue-config-split
branch
from
54d1d09 to
7d17391
Compare
sbalabanov
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Different subscriptions may need different settings (timeouts, retry
policies, batch sizes). Moving config from queue-level to Subscribe()
enables per-topic customization without creating separate Queue instances.
What?
retry, and DLQ settings
to prevent context.Canceled errors leaving partitions orphaned
Test Plan
bazel test and ran e2e queue tests