Skip to content

feat(ping api): adding fun exclamation to the response for empty request message #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinlnew merged 3 commits into from
Feb 23, 2026
Merged

feat(ping api): adding fun exclamation to the response for empty request message #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
def4f5a
feat(ping api): adding fun exclamation to the response
kevinlnew Feb 23, 2026
589a3a6
add for gateway
kevinlnew Feb 23, 2026
4ba92a0
Merge branch 'main' into kevin.new/fun-ping
kevinlnew Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gateway/controller/ping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (c *PingController) Ping(ctx context.Context, req *pb.PingRequest) (*pb.Pin

c.metricsScope.Counter("ping_requests_total").Inc(1)

message := "pong"
message := "pong!"
isEcho := false
if req.Message != "" {
message = "echo: " + req.Message
Expand Down
2 changes: 1 addition & 1 deletion gateway/controller/ping_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func TestPing_DefaultMessage(t *testing.T) {
resp, err := controller.Ping(ctx, req)

require.NoError(t, err)
assert.Equal(t, "pong", resp.Message)
assert.Equal(t, "pong!", resp.Message)
}

func TestPing_CustomMessage(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion orchestrator/controller/ping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (c *PingController) Ping(ctx context.Context, req *pb.PingRequest) (*pb.Pin

c.metricsScope.Counter("ping_requests_total").Inc(1)

message := "pong"
message := "pong!"
isEcho := false
if req.Message != "" {
message = "echo: " + req.Message
Expand Down
2 changes: 1 addition & 1 deletion orchestrator/controller/ping_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func TestPing_DefaultMessage(t *testing.T) {
resp, err := controller.Ping(ctx, req)

require.NoError(t, err)
assert.Equal(t, "pong", resp.Message)
assert.Equal(t, "pong!", resp.Message)
}

func TestPing_CustomMessage(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion speculator/controller/ping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (c *PingController) Ping(ctx context.Context, req *pb.PingRequest) (*pb.Pin

c.metricsScope.Counter("ping_requests_total").Inc(1)

message := "pong"
message := "pong!"
isEcho := false
if req.Message != "" {
message = "echo: " + req.Message
Expand Down
2 changes: 1 addition & 1 deletion speculator/controller/ping_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func TestPing_DefaultMessage(t *testing.T) {
resp, err := controller.Ping(ctx, req)

require.NoError(t, err)
assert.Equal(t, "pong", resp.Message)
assert.Equal(t, "pong!", resp.Message)
}

func TestPing_CustomMessage(t *testing.T) {
Expand Down