feat(entities) Adds change provider entity and mysql backed store for it by manjari25 · Pull Request #44 · uber/submitqueue

manjari25 · 2026-02-23T21:44:40Z

Summary

feat(entities) Adds change provider entity and mysql backed store for it

Why?

This sets up change provider entity and its corresponding sql store. This will be used by various workflows in the orchestrator to get information about changes going through the system.

What?

Add a ChangeProvider entity
Add a ChangeProviderStore - the mysql store that backs this entity

Test Plan

Issues

Stack

sbalabanov · 2026-02-23T22:14:58Z

@@ -0,0 +1,19 @@
+package entity
+
+type ChangeProvider struct {


plz comment the struct itself

sbalabanov · 2026-02-23T22:15:26Z

+	ID string
+	// Queue is the name of the queue processing the land request.
+	// This is defined in the configuration and should be unique within the system.
+	Queue string


probably not needed here

sbalabanov · 2026-02-23T22:16:27Z

+	ChangeProviderID string
+	// Metadata is the interesting data from the change provider that we want to store.
+	// This is a freeform JSON object.
+	Metadata map[string]any


may be [string]string to avoid ambiguity at the storage level and conversion errors?

sbalabanov · 2026-02-23T22:17:32Z

+	Metadata map[string]any
+	// Version is the version of the object. It is used for optimistic locking.
+	// Versioning starts at 1 and is incremented for each change to the object.
+	Version int32


ok to keep for now, not sure if we expect changes to this? I thought it should be fully immutable, unless we want to update data from the PRs periodically...

I removed this - version is not needed for this entity.

sbalabanov · 2026-02-23T22:18:30Z

@@ -0,0 +1,9 @@
+CREATE TABLE IF NOT EXISTS change_provider (
+    id VARCHAR(255) NOT NULL,
+    queue VARCHAR(255) NOT NULL,


queue is likely not needed, we have request id incorporating it

sbalabanov · 2026-02-23T22:26:22Z

+}
+
+// Create creates a new change provider from a request. Returns ErrAlreadyExists if the entry already exists.
+func (s *changeProviderStore) Create(ctx context.Context, request entity.Request) error {


I suggest to make ChangeProvider entity created by the app layer, and db layer is only to store or retrieve

I have changed this signature already.

sbalabanov · 2026-02-23T22:28:34Z

+	Get(ctx context.Context, id string) (entity.ChangeProvider, error)
+
+	// Create creates a new change provider.
+	Create(ctx context.Context, request entity.Request) error


ditto on above, storage layer store should in general not be aware of any entity other than the one it materializes.

I have changed this signature already.

sbalabanov · 2026-02-23T23:14:24Z

+	return &changeProviderStore{db: db}
+}
+
+// Get retrieves a change provider by ID. Returns ErrNotFound if the change provider is not found.


I guess it needs to retrieve all of the changes associated with the request? Also in the order specified in the request.

So it has to be an array or a separate entity

behinddwalls · 2026-02-23T23:39:35Z

@@ -0,0 +1,7 @@
+CREATE TABLE IF NOT EXISTS change_provider (
+    id VARCHAR(255) NOT NULL,


maybe we call it request_id

sqid :)
also in the Requests table :)

behinddwalls · 2026-02-24T00:34:15Z

+// to be the same as the request to which it belongs. The caller is repsonsible
+// for inspecting and mapping the result of this function to the
+// order of changes within the original request.
+//


nit: empty line

## Summary feat(entities) Adds batch entity and batch sql schema ## Why?  This sets up batch entity and its corresponding sql schema. This establishes the core concept of a batch that will be used through the system. ## What? * Add a `Batch` entity * Add `batch` mysql schema * Note: `BatchStore` in upcoming PR ## Test Plan ## Issues ## Stack 1. #44 1. @ #46 1. #47 1. #48 1. #49

## Summary feat(entities) Adds batch dependent entity and sql schema ## Why?  This sets up batch dependent entity and its corresponding sql schema. This helps make reverse look ups for batch dependencies easier throughout the system. ## What? * Add a `BatchDependent` entity * Add `batch_dependent` mysql schema * Note: `BatchDependentStore` in upcoming PR ## Test Plan ## Issues ## Stack 1. #44 1. #46 1. @ #47 1. #48 1. #49

sbalabanov · 2026-02-24T01:29:10Z

It seems that the comment about retrieveing an array of changes (or at least change ids) was not addressed?
Each request may specify more than one changeid, like in a case of stacked diffs.

manjari25 added 3 commits February 23, 2026 21:40

(entities) Adds change provider entity and mysql backed store for it

6b063a2

fix

076451a

fix land test to add new change provider store

49ab944

sbalabanov requested changes Feb 23, 2026

View reviewed changes

manjari25 added 4 commits February 23, 2026 22:30

version is not needed for the change provider

f78e09e

add description for ChangeProvider entity

a184bfa

remove queue from fields for ChangeProvider

c3406ad

update type of metadata

5312f79

manjari25 changed the title ~~(entities) Adds change provider entity and mysql backed store for it~~ feat (entities) Adds change provider entity and mysql backed store for it Feb 23, 2026

manjari25 changed the title ~~feat (entities) Adds change provider entity and mysql backed store for it~~ feat(entities) Adds change provider entity and mysql backed store for it Feb 23, 2026

manjari25 requested a review from sbalabanov February 23, 2026 22:56

manjari25 mentioned this pull request Feb 23, 2026

feat(entities) Adds batch entity and batch sql schema #46

Merged

sbalabanov requested changes Feb 23, 2026

View reviewed changes

manjari25 requested a review from sbalabanov February 23, 2026 23:19

behinddwalls reviewed Feb 23, 2026

View reviewed changes

manjari25 added 2 commits February 23, 2026 23:57

address comments

5704c39

fix

9fdcaf4

manjari25 requested a review from behinddwalls February 23, 2026 23:59

This was referenced Feb 24, 2026

feat(entities) Adds batch dependent entity and sql schema #47

Merged

feat(entities) Adds build entity and sql schema #48

Merged

behinddwalls reviewed Feb 24, 2026

View reviewed changes

Comment thread extension/storage/mysql/change_provider_store.go

comment

5c64579

behinddwalls approved these changes Feb 24, 2026

View reviewed changes

behinddwalls reviewed Feb 24, 2026

View reviewed changes

manjari25 mentioned this pull request Feb 24, 2026

feat(entities) Adds speculation tree entity and sql schema #49

Merged

behinddwalls marked this pull request as ready for review February 24, 2026 00:52

behinddwalls requested review from a team as code owners February 24, 2026 00:52

Merge branch 'main' into manjari/entities

91e968e

behinddwalls merged commit 3c25a2f into main Feb 24, 2026
1 check failed

		@@ -0,0 +1,7 @@
		CREATE TABLE IF NOT EXISTS change_provider (
		id VARCHAR(255) NOT NULL,

Conversation

manjari25 commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why?

What?

Test Plan

Issues

Stack

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manjari25 Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sbalabanov commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

manjari25 commented Feb 23, 2026 •

edited

Loading

manjari25 Feb 23, 2026 •

edited

Loading