Add hostname to Ping Response in example README#45
Closed
rashmi-prithyani wants to merge 3 commits into
Closed
Conversation
rashmi-prithyani
force-pushed
the
rprithyani/test-changes
branch
from
7d08b1e to
95b8523
Compare
rashmi-prithyani
changed the title
rashmi-prithyani
force-pushed
the
rprithyani/test-changes
branch
from
95b8523 to
035980d
Compare
rashmi-prithyani
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
Contributor
|
despite the relatively low importance of the change, still please provide a Summary, even a short one :) |
sbalabanov
approved these changes
Feb 23, 2026
The PingResponse proto and controller include a hostname field (field 4), but the README example was missing it in both the proto definition and the JSON response example. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rashmi-prithyani
force-pushed
the
rprithyani/test-changes
branch
from
035980d to
f0d81fb
Compare
Contributor
|
obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the hostname to the ping response in the example from README
Test Plan
Issues