feat(orchestrator): add pipeline stage controllers#63
Merged
Conversation
manjari25
reviewed
Feb 24, 2026
…te, build, merge, and finalize
behinddwalls
force-pushed
the
preetam/orch-stages
branch
from
dd416d8 to
dae55ea
Compare
kevinlnew
approved these changes
Feb 24, 2026
sbalabanov
reviewed
Feb 24, 2026
Contributor
sbalabanov
left a comment
sbalabanov
left a comment
There was a problem hiding this comment.
better have TODOs at appropriate controllers
| TopicBuildSignal Topic = "build-signal" | ||
| // TopicToMerge is where requests are published for merging. | ||
| TopicToMerge Topic = "to-merge" | ||
| // TopicMergeSignal is where merge signals are published for processing. |
Contributor
There was a problem hiding this comment.
from the description, not clear the difference from the previous one
| msg := delivery.Message() | ||
|
|
||
| // Deserialize request entity | ||
| request, err := entity.RequestFromBytes(msg.Payload) |
Contributor
There was a problem hiding this comment.
would it be a request that we trigger the build for? I thought it has to be a series of batches
| msg := delivery.Message() | ||
|
|
||
| // Deserialize request entity | ||
| request, err := entity.RequestFromBytes(msg.Payload) |
Contributor
There was a problem hiding this comment.
ditto, at least please add TODO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pipeline flow
Test plan