interface for change provider and update request to include uri#67
Merged
Conversation
f1f8ced to
4ed7258
Compare
sbalabanov
requested changes
Feb 25, 2026
eeeafdd to
fb4704a
Compare
sbalabanov
approved these changes
Feb 25, 2026
behinddwalls
approved these changes
Feb 25, 2026
c6d0bb2 to
80f57a1
Compare
80f57a1 to
c92e97c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the ChangeProvider extension interface and refactors the Change model to use URIs instead of simple IDs.
Changes
Added ChangeProvider interface to fetch changed files from external code review providers (GitHub, GitLab, Phabricator)
Interface method: Get(ctx context.Context, uris []string) ([]FileChange, error)
Returns list of files with their change status (added, modified, deleted)
Provider implementations will be added in subsequent PRs (e.g., extension/change_provider/github/)
Changed Change.ids to Change.uris throughout the codebase
URI format is provider-specific and self-contained:
GitHub: owner/repo/pr_number@commit_hash (e.g., uber/submitqueue/123@abc123defg)
Phabricator: revision_id@commit_hash (e.g., D12345@abc123def)
Updated proto, entity, storage, controllers, and tests
Test Plan
unit tests and ci
Issues