refactor(consumer): separate TopicKey from topic name in TopicRegistry#83
Merged
Conversation
sbalabanov
approved these changes
Feb 25, 2026
behinddwalls
force-pushed
the
preetam/topic-registry
branch
from
879b485 to
c861796
Compare
Remove redundant Topic field from SubscriptionConfig. The Subscriber.Subscribe() interface already takes topic as a separate parameter, so SubscriptionConfig.Topic was never read. Simplify DefaultSubscriptionConfig to take only subscriberName and consumerGroup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
behinddwalls
force-pushed
the
preetam/topic-registry
branch
from
c861796 to
553ddd5
Compare
manjari25
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopicKeyas a fixed pipeline stage identifier, separate from the actual queue topic name, allowing library consumers to provide their own naming conventionsTopicConfigstruct passed toNewTopicRegistryNewTopicRegistry(construction time) for fail-fast behaviorTest plan
make gazelle— BUILD files in sync