fix(targethasher): preserve query inputs#238
Open
sywhang wants to merge 1 commit into
Open
Conversation
Clone set-like protobuf slices before sorting and filter external URL attributes on a copied rule so hashing never mutates caller-owned query results. Add Rapid properties that permute target, dependency, attribute, and value ordering while asserting stable semantic hashes and byte-for-byte input immutability.
xytan0056
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toTarget shouldn't mutate the Target, but currently it is doing so when hashing the results.
Clone set-like protobuf slices before sorting and filter external URL attributes on a copied rule so hashing never mutates caller-owned query results.
Add Rapid properties that permute target, dependency, attribute, and value ordering while asserting stable semantic hashes and byte-for-byte input immutability.