Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Implement data structure modules for ITG. The OptimizedGraph structure provides fast look and calculation of reverse dependencies of a target to incrementally calculate the full target graph.
What?
New package: core/itg/graph
Data structures (graph.go)
attributes instead of strings (reduces memory)
tags, and attributes
automatically
Graph mutation (invalidate.go)
unblocked
Hash recomputation (update.go)
external rules, computes available hashes, invalidates stale entries, then recomputes hashes in topological
order
name), and rule targets (sha1 of rule attributes, without deps)
hashes, generated files inherit from their parent rule, and rule targets combine their HashWithoutDeps with
sorted dep hashes
Test Plan
unit test
Issue