Reserve id 0 in NameIDMapper for proto3 unset#93
Merged
Conversation
NameIDMapper handed out 0 as a legitimate id, colliding with proto3 semantics where 0 is the default/unset value for int32. Consumers using encoding/json (which honors omitempty) silently dropped any target, rule type, tag, or attribute whose id happened to be 0, making the entry invisible by name in the response. Start ids at 1 in both NameIDMapper and the topologically-ordered targetNamesMapping in ResultToGetTargetGraphResponse, keeping 0 reserved. Add a regression test asserting 0 is never assigned.
yushan8
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NameIDMapperhanded out 0 as a legitimate id, colliding with proto3 semantics where 0 is the default/unset value for int32. Consumers using encoding/json (which honors omitempty) silently dropped any target, rule type, tag, or attribute whose id happened to be 0, making the entry invisible by name in the response.that's why we have
where there's no ID. So our CLI call missed the target. It only happens to the first target entering
NewNameIDMapper.Start ids at 1 in both
NameIDMapperand the topologically-orderedtargetNamesMappinginResultToGetTargetGraphResponse, keeping 0 reserved. Add a regression test asserting 0 is never assigned.Test Plan
unit test
Issue