Propagate build description through all log lines#94
Merged
Conversation
xytan0056
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every log line now carries the full request context, making it possible to filter logs by a specific request in production.
Problem: The request fields (build_description, first_revision, second_revision) were attached to a context logger at the top of each RPC handler, but most
subsequent log calls — including inside compareTargetGraphs, compareTargetGraphsAndEdges, and throughout the orchestrator — used c.logger/b.logger directly,
silently dropping that context.
Changes:
Removes the per-call repetition of zap.Any("request build description", ...) (also fixes the inconsistent field name). Adds stage-level info logs: processing
start, checkout done, requests applied, cache hit/miss, and computation complete.
first_revision/second_revision) instead of the bare c.logger. The compareTargetGraphs and compareTargetGraphsAndEdges helpers now accept a *zap.Logger parameter
(replacing the unused ctx parameter) so their logs also carry the request context.
Apply() — fetch, diff, apply patch, commit, submodule update — now logs on start and on failure with request_id, base_ref, and commit.