Make max_distance configurable via RepositoryConfig#95
Merged
Conversation
xytan0056
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a server-side default for BFS distance trimming so operators can cap which changed targets are returned without requiring every client to set output_config.max_distance.
What changed
config.RepositoryConfig — new max_distance field (YAML: max_distance). 0 means unset; positive values enable distance trimming at that depth.
config.RepositoryConfigProvider — new interface with a single GetRepositoryConfig(remote string) (RepositoryConfig, bool) method. *config.Config implements it
(verified by a compile-time check). Future implementations (e.g. a remote config service) can be swapped in without touching the controller.
controller — the controller now accepts a RepositoryConfigProvider (optional, safe when nil) instead of *config.Config directly. A new resolveMaxDistance function
merges the two sources with clear priority:
The resolved maxDist is computed once per request and threaded through compareTargetGraphs, compareTargetGraphsAndEdges, sendWithDistanceFilter, and
sendWithDistanceFilterForEdges, which now take int32 maxDist directly instead of *pb.OutputConfig.
Test plan
config)