Add more granular metrics on failed requests#98
Merged
Conversation
|
|
justinwon777
reviewed
Jun 2, 2026
justinwon777
reviewed
Jun 2, 2026
justinwon777
reviewed
Jun 2, 2026
| if err != nil { | ||
| logger.Error("GetChangedTargets: Failed to compare target graphs", zap.Error(err)) | ||
| failureReason = "compare" | ||
| return fmt.Errorf("failed to compare target graphs: %w", err) |
Contributor
There was a problem hiding this comment.
Should we define custom error types in errors.go, so that in classifyError it can just match the error type instead of looking for strings. I believe that's the best practice for our internal services. Then maybe all the classification can happen inside classifyError instead of doing some in there and some like this.
Contributor
Author
There was a problem hiding this comment.
Yes good point. Created an interface for ClassifyError. That way we can categorize failures internally.
justinwon777
reviewed
Jun 3, 2026
justinwon777
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more granular metrics for different failure categories.