Skip to content

User location checking fixes#84

Open
thilan-tran wants to merge 1 commit intomainfrom
thilan/location
Open

User location checking fixes#84
thilan-tran wants to merge 1 commit intomainfrom
thilan/location

Conversation

@thilan-tran
Copy link
Contributor

@thilan-tran thilan-tran commented May 26, 2021

Changes

  • removed alert popping up when location permissions are successfully given
  • made it so that Map will render even if user location is not available
    • the bot popup will have an empty string in the lower corner, instead of "0 miles away"
  • clarified the alert popup actions when permissions are not available
    • user can continue without their location
    • or alternatively open settings to configure permissions
  • removed duplicate alerts from popping up

No visual changes, except for alert text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant