Conversation
|
To do:
|
R/angles.R
Outdated
| if (parent.id == -1) { | ||
| tree$angle[tree$tip == current.node.id] <- start.angle; | ||
| } | ||
| # if (parent.id == -1) { |
There was a problem hiding this comment.
Are you sure don't need this root node case anymore?
There was a problem hiding this comment.
I remember this is a duplicated statement from make.clone.tree.grobs.R line 79.
R/angles.R
Outdated
| v = v, | ||
| dx.scale = median(tree$length1) | ||
| ); | ||
| # angles[tree$tip %in% child.ids] <- start.angle + angles[tree$tip %in% child.ids]; |
There was a problem hiding this comment.
Same question here. We're sure that split.equal.x.dist accounts for the parent angle properly?
There was a problem hiding this comment.
This is from my naive try to just add start.angle to the dendrogram, but it doesn't exist prior to this PR.
|
|
||
| rotated <- rotate.dendrogram(df, rotate.by = pi / 2); | ||
|
|
||
| expect_equal(dim(rotated), dim(df)); |
There was a problem hiding this comment.
Fine for now. If we start getting more complex failures, it may be good to split each requirement into separate unit test cases. As it's written now, if theres a failure on line 39, line 40 won't be checked (for example).
2 participants
Description
Support rotating dendrogram trees
Small example
Checklist
This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
Disclosing PHI is a major problem1 - Even a small leak can be costly2.
This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.
.png, .jpeg),.pdf,.RData,.xlsx,.doc,.ppt, or other output files.To automatically exclude such files using a .gitignore file, see here for example.
I have read the code review guidelines and the code review best practice on GitHub check-list.
I have set up or verified the
mainbranch protection rule following the github standards before opening this pull request.The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have added the major changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.Footnotes
UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records ↩
The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records. ↩
Genetic information is considered PHI.
Forensic assays can identify patients with as few as 21 SNPs ↩
RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity. ↩