Conversation
🦋 Changeset detectedLatest commit: f33726b The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce2bd6c68c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (op.type === 'set_selection' && !isInTransaction(editor)) { | ||
| setCurrentMarks(editor, null) |
There was a problem hiding this comment.
The set_selection mark reset is now guarded by !isInTransaction(editor), but this code path executes only after apply has entered a transaction (either directly or via the runEditorTransaction wrapper), so the condition is never true. In editors with listeners (the common slate-react path), selection changes no longer clear pending marks, so subsequent typing can incorrectly inherit stale formatting after cursor moves. This regresses the prior behavior noted by the inline comment and can surface as unexpected bold/italic carryover.
Useful? React with 👍 / 👎.
Harden the @slate/yjs controller and operations so concurrent wrap, move, merge, unwrap, and reconnect edits resolve to consistent Yjs paths, and fix offline split undo/redo convergence. Adds contract and structural soak tests covering split/merge, operation exhaustiveness, provider, and React bindings.
Record the yjs-pr21 research run (brief, plan, synthesis, quality gaps, sources, tasks, and soak/split-merge bug notes) and route gaps to the slate-ar pipeline.
Record remote import trace metadata, split Yjs collaboration benchmark phases, and keep restored soak runners manual-only by removing package script entry points and stale release-proof soak claims.
feat(yjs): add Slate Yjs collaboration package
2 participants
Description
A clear and concise description of what this pull request solves. (Please do not just link to a long issue thread. Instead include a clear description here or your pull request will likely not be reviewed as quickly.)
Issue
Fixes: (link to issue)
Example
A GIF or video showing the old and new behaviors after this pull request is merged. Or a code sample showing the usage of a new API. (If you don't include this, your pull request will not be reviewed as quickly, because it's much too hard to figure out exactly what is going wrong, and it makes maintenance much harder.)
Context
If your change is non-trivial, please include a description of how the new logic works, and why you decided to solve it the way you did. (This is incredibly helpful so that reviewers don't have to guess your intentions based on the code, and without it your pull request will likely not be reviewed as quickly.)
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)